perf: fallback to module level registry in browser #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Dec 20, 2021
timneutkens
reviewed
Dec 20, 2021
huozhi
force-pushed
the
fallback-client-registry
branch
from
8c717cc
to
f584ee5
Compare
timneutkens
approved these changes
Dec 22, 2021
|
🎉 This PR is included in version 5.0.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
huozhi
added a commit
that referenced
this pull request
Jan 20, 2022
* perf: fallback to module level registry in browser * preeval registry at top level * use typeof for conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to module level local registry on client side, so we don't have to include a registry there.
StyleRegistryis only required for server render for safe concurrent renderingUse
typeof window(instead ofprocess.browser) for determine envrionment which we can optimize later on bundler side.Tested with next.js styled-jsx example
x-ref: vercel/next.js#32417
x-ref: vercel/next.js#30377