Considering enabling react/no-unknown-property
#52
Comments
|
It's very easy to dismiss these and end up with a console full of errors:
|
|
I'd be strongly in favor. |
|
We initially didn't turn this on as we preference TypeScript, and obviously this should be flagged in TypeScript as invalid - but we didn't consider the auto-fix aspect, which is really great. |
|
Hi hi! Checking in to see if there's any movement or further consideration for this? Really missing this every day! |
|
We definitely plan to enable this, but it'll be a breaking change (a change to a default) so we were hoping to group it with some other items. I was hoping to group it with #54 which is apparently close to shipping. |
|
Hi! I'm still very bogged down by converting casing. I bet I'm not alone here, getting this in would be a tiny but mighty DX win across the Engineering org. |
Resolves #52 BREAKING CHANGE: `react/no-unknown-property` has been enabled as it provides a useful auto-fix for SVG properties.
Resolves #52 BREAKING CHANGE: `react/no-unknown-property` has been enabled as it provides a useful auto-fix for SVG properties.
Resolves #52 BREAKING CHANGE: `react/no-unknown-property` has been enabled as it provides a useful auto-fix for SVG properties.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: |
Today, when copying SVG elements from Figma to React, many of the properties will be in snake case (
stroke-width) but in React we need them to be camel case (strokeWidth)Right now, there's no way to autofix those errors so a lot of time is spent on manually find and replacing on each SVG copied over. I've previously enabled
react/no-unknown-propertywhich will auto-fix the SVG errors:Thanks!
The text was updated successfully, but these errors were encountered: