Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanUrls option to CLI interface #785

Open
joeuy opened this issue Sep 19, 2023 · 0 comments
Open

Add cleanUrls option to CLI interface #785

joeuy opened this issue Sep 19, 2023 · 0 comments

Comments

@joeuy
Copy link

joeuy commented Sep 19, 2023

Description

Currently cleanUrls is only configurable via a specific config file. I am suggesting and would be happy to send PR to add a CLI option to control cleanUrls. Very similar change to --no-request-logging https://github.com/vercel/serve/pull/716/files

Why

Currently cleanUrls is only configurable via a specific config file. Creating a configuration file just for this option could cause confusion/maintenance hassle as people don't know the file path to config should be specified relative to the public folder.

Additional it seems odd that some options are configurable via CLI and others are not.

Example issues people are facing: #732 and #722

Alternatives

  1. create a config file.
  2. add --config CLI argument, and make sure path is correct to each public folder being served.
@joeuy joeuy changed the title Add cleanUrls option to serve CLI interface Add cleanUrls option to CLI interface Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant