From 9984ef901c7b8423dac5962f31ebcfb03359d2a4 Mon Sep 17 00:00:00 2001 From: Shu Ding Date: Mon, 15 Aug 2022 19:36:28 +0200 Subject: [PATCH] eliminate some deps from base server --- packages/next/server/base-server.ts | 15 --------------- packages/next/server/next-server.ts | 15 ++++++++++++++- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/packages/next/server/base-server.ts b/packages/next/server/base-server.ts index aa777663fbbd..f2d03427c6dd 100644 --- a/packages/next/server/base-server.ts +++ b/packages/next/server/base-server.ts @@ -28,14 +28,11 @@ import type { PagesManifest } from '../build/webpack/plugins/pages-manifest-plug import type { BaseNextRequest, BaseNextResponse } from './base-http' import type { PayloadOptions } from './send-payload' -import { join } from '../shared/lib/isomorphic/path' import { parse as parseQs } from 'querystring' import { format as formatUrl, parse as parseUrl } from 'url' import { getRedirectStatus } from '../lib/redirect-status' import { NEXT_BUILTIN_DOCUMENT, - SERVERLESS_DIRECTORY, - SERVER_DIRECTORY, STATIC_STATUS_PAGES, TEMPORARY_REDIRECT_STATUS, } from '../shared/lib/constants' @@ -46,7 +43,6 @@ import { checkIsManualRevalidate, } from './api-utils' import * as envConfig from '../shared/lib/runtime-config' -import { isTargetLikeServerless } from './utils' import Router from './router' import { getPathMatch } from '../shared/lib/router/utils/path-match' import { setRevalidateHeaders } from './send-payload/revalidate-headers' @@ -2124,17 +2120,6 @@ export default abstract class Server { res.statusCode = 404 return this.renderError(null, req, res, pathname!, query, setHeaders) } - - protected get _isLikeServerless(): boolean { - return isTargetLikeServerless(this.nextConfig.target) - } - - protected get serverDistDir() { - return join( - this.distDir, - this._isLikeServerless ? SERVERLESS_DIRECTORY : SERVER_DIRECTORY - ) - } } export { stringifyQuery } from './server-route-utils' diff --git a/packages/next/server/next-server.ts b/packages/next/server/next-server.ts index 3b67eda39e52..f120b98c03a4 100644 --- a/packages/next/server/next-server.ts +++ b/packages/next/server/next-server.ts @@ -39,6 +39,8 @@ import { CLIENT_PUBLIC_FILES_PATH, APP_PATHS_MANIFEST, FLIGHT_SERVER_CSS_MANIFEST, + SERVERLESS_DIRECTORY, + SERVER_DIRECTORY, } from '../shared/lib/constants' import { recursiveReadDirSync } from './lib/recursive-readdir-sync' import { format as formatUrl, UrlWithParsedQuery } from 'url' @@ -84,7 +86,7 @@ import { removeTrailingSlash } from '../shared/lib/router/utils/remove-trailing- import { getNextPathnameInfo } from '../shared/lib/router/utils/get-next-pathname-info' import { bodyStreamToNodeStream, getClonableBody } from './body-streams' import { checkIsManualRevalidate } from './api-utils' -import { shouldUseReactRoot } from './utils' +import { shouldUseReactRoot, isTargetLikeServerless } from './utils' import ResponseCache from './response-cache' import { IncrementalCache } from './lib/incremental-cache' import { getSortedRoutes } from '../shared/lib/router/utils/sorted-routes' @@ -1712,4 +1714,15 @@ export default class NextNodeServer extends BaseServer { return result } + + protected get _isLikeServerless(): boolean { + return isTargetLikeServerless(this.nextConfig.target) + } + + protected get serverDistDir() { + return join( + this.distDir, + this._isLikeServerless ? SERVERLESS_DIRECTORY : SERVER_DIRECTORY + ) + } }