From cf87e666dd360c783f2a628b6b2eda4e8d345e0b Mon Sep 17 00:00:00 2001 From: Tim Neutkens Date: Fri, 12 Aug 2022 21:59:07 +0200 Subject: [PATCH] Rename page -> entry in on-demand-entry-handler --- .../server/dev/on-demand-entry-handler.ts | 37 +++++++++---------- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/packages/next/server/dev/on-demand-entry-handler.ts b/packages/next/server/dev/on-demand-entry-handler.ts index d9055ab2e948abd..4c1b96a23dca003 100644 --- a/packages/next/server/dev/on-demand-entry-handler.ts +++ b/packages/next/server/dev/on-demand-entry-handler.ts @@ -398,34 +398,34 @@ export function onDemandEntryHandler({ const isInsideAppDir = appDir && pagePathData.absolutePagePath.startsWith(appDir) - const addPageEntry = ( + const addEntry = ( compilerType: CompilerNameValues ): { - pageKey: string + entryKey: string newEntry: boolean shouldInvalidate: boolean } => { - const pageKey = `${compilerType}${pagePathData.page}` + const entryKey = `${compilerType}${pagePathData.page}` - if (entries[pageKey]) { - entries[pageKey].dispose = false - entries[pageKey].lastActiveTime = Date.now() - if (entries[pageKey].status === BUILT) { + if (entries[entryKey]) { + entries[entryKey].dispose = false + entries[entryKey].lastActiveTime = Date.now() + if (entries[entryKey].status === BUILT) { return { - pageKey, + entryKey, newEntry: false, shouldInvalidate: false, } } return { - pageKey, + entryKey, newEntry: false, shouldInvalidate: true, } } - entries[pageKey] = { + entries[entryKey] = { type: EntryTypes.ENTRY, absolutePagePath: pagePathData.absolutePagePath, request: pagePathData.absolutePagePath, @@ -436,7 +436,7 @@ export function onDemandEntryHandler({ } return { - pageKey, + entryKey: entryKey, newEntry: true, shouldInvalidate: true, } @@ -447,10 +447,7 @@ export function onDemandEntryHandler({ nextConfig, }) - const added = new Map< - CompilerNameValues, - ReturnType - >() + const added = new Map>() await runDependingOnPageType({ page: pagePathData.page, @@ -460,15 +457,15 @@ export function onDemandEntryHandler({ if (isServerComponent || isInsideAppDir) { return } - added.set(COMPILER_NAMES.client, addPageEntry(COMPILER_NAMES.client)) + added.set(COMPILER_NAMES.client, addEntry(COMPILER_NAMES.client)) }, onServer: () => { - added.set(COMPILER_NAMES.server, addPageEntry(COMPILER_NAMES.server)) + added.set(COMPILER_NAMES.server, addEntry(COMPILER_NAMES.server)) }, onEdgeServer: () => { added.set( COMPILER_NAMES.edgeServer, - addPageEntry(COMPILER_NAMES.edgeServer) + addEntry(COMPILER_NAMES.edgeServer) ) }, }) @@ -489,9 +486,9 @@ export function onDemandEntryHandler({ if (entriesThatShouldBeInvalidated.length > 0) { const invalidatePromises = entriesThatShouldBeInvalidated.map( - ({ pageKey }) => { + ({ entryKey }) => { return new Promise((resolve, reject) => { - doneCallbacks!.once(pageKey, (err: Error) => { + doneCallbacks!.once(entryKey, (err: Error) => { if (err) { return reject(err) }