From 373d52a21453178b34befa5ba806546bff3f85ff Mon Sep 17 00:00:00 2001 From: OJ Kwon Date: Fri, 8 Jul 2022 17:35:34 -0700 Subject: [PATCH] fix(next/build): correct payload for plugin telemetry --- packages/next/telemetry/events/swc-plugins.ts | 8 ++++---- test/integration/telemetry/test/index.test.js | 14 ++++++-------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/packages/next/telemetry/events/swc-plugins.ts b/packages/next/telemetry/events/swc-plugins.ts index 329337d1af5b..7a0d9ee8473e 100644 --- a/packages/next/telemetry/events/swc-plugins.ts +++ b/packages/next/telemetry/events/swc-plugins.ts @@ -5,8 +5,8 @@ const EVENT_SWC_PLUGIN_PRESENT = 'NEXT_SWC_PLUGIN_DETECTED' type SwcPluginsEvent = { eventName: string payload: { - packageName: string - packageVersion?: string + pluginName: string + pluginVersion?: string } } @@ -34,8 +34,8 @@ export async function eventSwcPlugins( events.push({ eventName: EVENT_SWC_PLUGIN_PRESENT, payload: { - packageName: plugin, - packageVersion: version, + pluginName: plugin, + pluginVersion: version, }, }) diff --git a/test/integration/telemetry/test/index.test.js b/test/integration/telemetry/test/index.test.js index 7d65a87a069e..d4a810ed7015 100644 --- a/test/integration/telemetry/test/index.test.js +++ b/test/integration/telemetry/test/index.test.js @@ -843,19 +843,17 @@ describe('Telemetry CLI', () => { const regex = /NEXT_SWC_PLUGIN_DETECTED[\s\S]+?{([\s\S]+?)}/g const coverage = regex.exec(stderr).pop() - expect(coverage).toContain( - `"packageName": "swc-plugin-coverage-instrument"` - ) - expect(coverage).toContain(`"packageVersion": "0.0.6"`) + expect(coverage).toContain(`"pluginName": "swc-plugin-coverage-instrument"`) + expect(coverage).toContain(`"pluginVersion": "0.0.6"`) const relay = regex.exec(stderr).pop() - expect(relay).toContain(`"packageName": "@swc/plugin-relay"`) - expect(relay).toContain(`"packageVersion": "0.2.0"`) + expect(relay).toContain(`"pluginName": "@swc/plugin-relay"`) + expect(relay).toContain(`"pluginVersion": "0.2.0"`) const absolute = regex.exec(stderr).pop() expect(absolute).toContain( - `"packageName": "/test/absolute_path/plugin.wasm"` + `"pluginName": "/test/absolute_path/plugin.wasm"` ) - expect(absolute).not.toContain(`packageVersion`) + expect(absolute).not.toContain(`pluginVersion`) }) })