From 483243e680fc7bcf835a37c518d09c51fcd296a0 Mon Sep 17 00:00:00 2001 From: Ludovico Fischer Date: Wed, 13 Jan 2021 21:49:33 +0100 Subject: [PATCH] fix: bump node-sass peer dependency Get rid of the unmet peer dependency warning when installing a next.js project wtih node-sass 5. node-sass 5 is the currently maintained version and removes support one deprecated API and Node.js versions that Next.js does not support either. Next.js uses node-sass 5 in devDependencies. node-sass changelog: https://github.com/sass/node-sass/releases On the other hand, as the docs encourage the sass package instead of node-sass, (see errors/duplicate-sass.md) I have updated examples which used node-sass 4 to the latest sass instead. --- examples/with-carbon-components/package.json | 2 +- examples/with-react-md-typescript/package.json | 2 +- examples/with-storybook-styled-jsx-scss/package.json | 2 +- examples/with-styled-jsx-scss/package.json | 4 ++-- packages/next/package.json | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/with-carbon-components/package.json b/examples/with-carbon-components/package.json index 223888eac60ac69..abf06ee2779cba5 100644 --- a/examples/with-carbon-components/package.json +++ b/examples/with-carbon-components/package.json @@ -15,7 +15,7 @@ "carbon-components-react": "^7.3.0", "carbon-icons": "^7.0.7", "next": "latest", - "node-sass": "^4.12.0", + "sass": "^1.32.4", "react": "^16.7.0", "react-dom": "^16.7.0" } diff --git a/examples/with-react-md-typescript/package.json b/examples/with-react-md-typescript/package.json index cd82e062a0815b0..ef320ad29db3555 100644 --- a/examples/with-react-md-typescript/package.json +++ b/examples/with-react-md-typescript/package.json @@ -17,7 +17,7 @@ "devDependencies": { "@types/node": "^14.0.27", "@types/react": "^16.9.43", - "node-sass": "^4.14.1", + "sass": "^1.32.4", "typescript": "^3.9.7" } } diff --git a/examples/with-storybook-styled-jsx-scss/package.json b/examples/with-storybook-styled-jsx-scss/package.json index 0a85565d4b3ce1b..b782c55e7c9a60c 100644 --- a/examples/with-storybook-styled-jsx-scss/package.json +++ b/examples/with-storybook-styled-jsx-scss/package.json @@ -11,7 +11,7 @@ }, "dependencies": { "next": "^10.0.0", - "node-sass": "^4.14.1", + "sass": "^1.32.4", "react": "17.0.1", "react-dom": "17.0.1", "styled-jsx-plugin-sass": "^1.0.0" diff --git a/examples/with-styled-jsx-scss/package.json b/examples/with-styled-jsx-scss/package.json index 60cb944c0d10a8b..8a66582452b988d 100644 --- a/examples/with-styled-jsx-scss/package.json +++ b/examples/with-styled-jsx-scss/package.json @@ -8,10 +8,10 @@ }, "dependencies": { "next": "latest", - "node-sass": "4.5.3", + "sass": "1.32.4", "react": "^16.7.0", "react-dom": "^16.7.0", - "styled-jsx-plugin-sass": "0.2.0" + "styled-jsx-plugin-sass": "1.0.0" }, "license": "MIT" } diff --git a/packages/next/package.json b/packages/next/package.json index 27d4be7daa5a843..621085a3e54c96c 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -112,7 +112,7 @@ }, "peerDependencies": { "fibers": ">= 3.1.0", - "node-sass": "^4.0.0", + "node-sass": "^5.0.0", "react": "^16.6.0 || ^17", "react-dom": "^16.6.0 || ^17", "sass": "^1.3.0"