Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy button in with-xata example #43608

Merged
merged 3 commits into from Dec 1, 2022

Conversation

SferaDev
Copy link
Contributor

@SferaDev SferaDev commented Dec 1, 2022

The deploy button of the with-xata example is not working properly because we were lacking the integration to configure the env variables.

Deploy with Vercel

Taking advantage of the PR, some other changes:

  • Adding alt to next/image to fix build with latest version
  • Update readme to add more information in the Xata CLI section
  • Use a new command to initialize the database schema on first deployment
  • Remove hardcoded URL in xata.codegen.ts
  • Remove deprecated formatVersion in schema.template.json
  • Update dependencies

Note: The integration is still work in progress, it works for the Deploy to Vercel button but we want to improve the UI/UX before submitting it to the Marketplace, keeping it unlisted for a while.

cc: @atilafassina

@ijjk ijjk added the examples Issue/PR related to examples label Dec 1, 2022
@ijjk ijjk merged commit a45bf8c into vercel:canary Dec 1, 2022
@SferaDev SferaDev deleted the fix-with-xata-deploy branch December 1, 2022 19:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants