Changed output mode on app directory test application #43607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
requested review from
timneutkens,
ijjk,
shuding and
huozhi
as code owners
balazsorban44
approved these changes
Dec 1, 2022
ijjk
added a commit
that referenced
this pull request
Dec 2, 2022
This test was ensuring `app` directory is working correctly with `output: 'standalone'`. Instead of removing config we should conditionally set it for the test. Reverts #43607 x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832699 x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832421
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables standalone output mode for app directory tests until some issues are resolved around it. Should be re-enabled once the issues have been resolved.
x-ref: https://vercel.slack.com/archives/C035J346QQL/p1669829521120779