Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): fix CLI commands for MobX examples #43534

Merged
merged 3 commits into from Nov 29, 2022
Merged

chore(examples): fix CLI commands for MobX examples #43534

merged 3 commits into from Nov 29, 2022
+10 −10

Conversation

Haschikeks
Copy link
Contributor

@Haschikeks Haschikeks commented Nov 29, 2022 •
edited

Update with-mobx example README.md

Fixes #43512

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Nov 29, 2022
@balazsorban44 balazsorban44 changed the title Fix 43512 chore(examples): fix CLI commands for MobX examples Nov 29, 2022
@Haschikeks
Update with-mobx-state-tree example README.md
fe8903b 
Update external links & create commands
@Haschikeks
Copy link
Contributor Author

thanks for updating the title, will keep that format in mind, if I do more PRs, @balazsorban44
added the commit for with-mobx-state-tree

@balazsorban44
Copy link
Member

Thanks!

@balazsorban44 balazsorban44 merged commit f15b5d0 into vercel:canary Nov 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with-mobx example install command
3 participants
@Haschikeks @balazsorban44 @ijjk