docs: update known Safari bug #43513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alantoa
requested review from
timneutkens,
ijjk,
shuding and
styfle
as code owners
styfle
reviewed
Nov 29, 2022
styfle
reviewed
Nov 29, 2022
docs/api-reference/next/image.md
Outdated
| clip-path: inset(0.5px); | ||
| } | ||
| } | ||
| /* Safari v16.0+ */ |
There was a problem hiding this comment.
Can we target both safari 15 and 16 with a single media query?
There was a problem hiding this comment.
using:
@media (min-resolution: 0.001dpcm) {
@supports (-webkit-appearance: none) and (stroke-color: transparent) {
}
}
media query should work but would make the example less clear I think.
write this doc just to explain to developers, because in fact, developers still need to change it, such as 0.5px maybe need to change 1px.
WDYT?
There was a problem hiding this comment.
I think 1px will be too much and make the image look smaller in Safari. We want this value to be the smallest possible change to the page while still removing the border.
There was a problem hiding this comment.
got it! thank you!
anyway, is a good way to fix this!
styfle
reviewed
Nov 29, 2022
styfle
previously approved these changes
Nov 29, 2022
1 task
styfle
reviewed
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
hey, teams!
since Safari
v16is supported resolution media query, so this before docs the@media not all and (min-resolution: 0.001dpcm)media query will not work on Safari latest version.so I update the docs for
next/imageKnown Browser Bugs, hope this can help developers.Documentation / Examples
pnpm build && pnpm lint