Clarify that publicRuntimeConfig and serverRuntimeConfig do not work with Output File Tracing #43443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Output File Tracing This is mentioned in Output File Tracing page but not this page. This led me into a wrong path for a while.
dtinth
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia,
leerob and
balazsorban44
as code owners
delbaoliveira
approved these changes
Nov 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Output File Tracing page mentioned that
publicRuntimeConfigandserverRuntimeConfigare now legacy and does not work with Output File Tracing (they are inlined at build-time instead of being set at runtime, the way it is supposed to work).However, the Runtime Config page itself does not mention this at all. This led me into a wrong path for a while.
Documentation / Examples
pnpm build && pnpm lint