Fix with-docker-compose example
#43419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxproske
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
brvnonascimento
pushed a commit
to brvnonascimento/next.js
that referenced
this pull request
Nov 28, 2022
1. Fixes example unable to build with the latest version of Next. - Next.js 13 bumped the minimum React version to [18.2.0](https://nextjs.org/docs/upgrading), but this example seems to have gotten missed. 2. Fixes example unable to run by default on Linux. - Reverts vercel#39372 - Fixes @balazsorban44 comment vercel#39372 (comment) - Added a comment to the README to prevent this issue from being re-introduced. 3. Build and start Next.js based on the preferred package manager. 4. Allow dependencies to install without lockfile present. - Outputs a warning instead of exiting. - Keeps the example faithful to the README "Develop locally without Node.js or TypeScript installed". 5. Added `next.config.js` types that got missed. 6. Updated README links now that output standalone is stable. ## Documentation / Examples - [X] Make sure the linting passes by running `pnpm build && pnpm lint` - [X] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and start Next.js based on the preferred package manager.
Allow dependencies to install without lockfile present.
Added
next.config.jstypes that got missed.Updated README links now that output standalone is stable.
Documentation / Examples
pnpm build && pnpm lint