Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): re-export PageComponent and LayoutComponent types #43226

Merged
merged 1 commit into from Nov 22, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Nov 22, 2022

Fixes #43195, fixes #41901, fixes #42042

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk
Copy link
Member

ijjk commented Nov 22, 2022

Failing test suites

Commit: d1cf6ef

pnpm testheadless test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app > logbox: can recover from a syntax error without losing state
  • ReactRefreshLogBox app > render error not shown right after syntax error
Expand output

● ReactRefreshLogBox app › logbox: can recover from a syntax error without losing state

TIMED OUT: /Count: 1/

Count: 0

  532 |
  533 |   if (hardError) {
> 534 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  535 |   }
  536 |   return false
  537 | }

  at check (lib/next-test-utils.js:534:11)
  at Object.<anonymous> (development/acceptance-app/ReactRefreshLogBox.test.ts:107:5)

● ReactRefreshLogBox app › render error not shown right after syntax error

expect(received).toMatchSnapshot()

Snapshot name: `ReactRefreshLogBox app render error not shown right after syntax error 1`

Snapshot: "index.js (6:18) @ ClassDefault.render

  4 | class ClassDefault extends React.Component {
  5 |   render() {
> 6 |     throw new Error('nooo');
    |          ^
  7 |     return <h1>Default Export</h1>;
  8 |   }
  9 | }"
Received: null

  327 |     )
  328 |     expect(await session.hasRedbox(true)).toBe(true)
> 329 |     expect(await session.getRedboxSource()).toMatchSnapshot()
      |                                             ^
  330 |
  331 |     await cleanup()
  332 |   })

  at Object.<anonymous> (development/acceptance-app/ReactRefreshLogBox.test.ts:329:45)

Read more about building and testing Next.js in contributing.md.

@imranbarbhuiya
Copy link
Contributor

This also fixes #41901 and #42042

@balazsorban44 balazsorban44 merged commit 7596132 into canary Nov 22, 2022
@balazsorban44 balazsorban44 deleted the fix/issue-43195 branch November 22, 2022 12:49
jankaifer pushed a commit to jankaifer/next.js that referenced this pull request Nov 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants