feat(examples): use experimental edge runtime with grafbase #42992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notrab
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
notrab
changed the title
ijjk
reviewed
Nov 16, 2022
| @@ -4,6 +4,7 @@ const nextConfig = { | |||
| swcMinify: true, | |||
| experimental: { | |||
| appDir: true, | |||
| runtime: 'experimental-edge', | |||
There was a problem hiding this comment.
Adding this to the root config will currently make all app paths dynamic and revalidate won't be able to be honored currently.
There was a problem hiding this comment.
Is the mentioned behavior desired? If so it may confuse users as revalidate is being configured but not used here.
There was a problem hiding this comment.
@ijjk I totally missed revalidate was still exported. Thank you
I will update this to be export const revalidate = 0 so it's always rendered dynamically or remove it completely...
ijjk
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the experimental runtime as shown in a guide that links to this example.
Examples
pnpm build && pnpm lint