Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove with-atlaskit example #42973

Merged
merged 2 commits into from Nov 16, 2022

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Nov 16, 2022

As of Next.js 13, the minimum React version was bumped to 18.2.0. However, the maximum React version supported by most Atlaskit packages (including @atlaskit/button and @atlaskit/form) is 16.8.0.

The example is unable to build with next@latest, therefore I am deprecating removing it.

x-refs:

carbon (3)

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Nov 16, 2022
@leerob
Copy link
Member

leerob commented Nov 16, 2022

For less common examples, like this, let's delete the entire folder 👍

@maxproske maxproske changed the title Deprecate with-atlaskit example Remove with-atlaskit example Nov 16, 2022
@maxproske
Copy link
Contributor Author

@leerob RIP in pepperoni

@balazsorban44 balazsorban44 merged commit a916553 into vercel:canary Nov 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants