Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add postgres.js example #42962

Merged
merged 3 commits into from Nov 16, 2022
Merged

docs(examples): add postgres.js example #42962

merged 3 commits into from Nov 16, 2022

Conversation

silvioprog
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the area: examples Anything inside the examples folder label Nov 15, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some comments.

@silvioprog
Copy link
Contributor Author

Thanks a lot for the tips. Refactored as suggested! :)

@maxproske
Copy link
Contributor

Cool! I'm excited to see the first postgres data fetching example get added. 🎉

@balazsorban44 balazsorban44 merged commit 10b635e into vercel:canary Nov 16, 2022
@silvioprog silvioprog deleted the new-example-with-postgres branch November 16, 2022 21:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: examples Anything inside the examples folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants