feat(examples): with-grafbase #42898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reviewing @balazsorban44. I didn't quite finish pushing changes yesterday hence the draft PR so most of your comments should be resolved in that. |
notrab
requested review from
timneutkens,
ijjk,
shuding,
leerob and
steven-tey
as code owners
balazsorban44
requested changes
Nov 15, 2022
There was a problem hiding this comment.
Can you make sure that linting passes? https://github.com/vercel/next.js/actions/runs/3469499938/jobs/5796602833
you can run pnpm prettier --write examples/with-grafbase and commit the changed files
notrab
force-pushed
the
gb-2460-pr-with-grafbase-example-to-nextjs
branch
from
7a6619f
to
650b4d7
Compare
|
@balazsorban44 all done 🙌🏻 |
balazsorban44
approved these changes
Nov 15, 2022
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
with-grafbaseexample.with-prefix can be removed to follow guidelines but unsure if this is outdated since all other examples include this for similar services.Documentation / Examples
pnpm build && pnpm lintTodo