Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/advanced-features/debugging.md #42842

Merged
merged 2 commits into from Nov 14, 2022

Conversation

KoltonG
Copy link
Contributor

@KoltonG KoltonG commented Nov 13, 2022

Updated .vscode/launch.json debugging file due to the following errors:

  • type: pwa-chrome shows an eslint error recommending type chrome
  • console key is now deprecated.

Tested client and server-side debugging on:

  • Mac v12.6 (21G115)
  • VSCode v1.73.1
  • Chrome v107.0.5304.110

See attached screenshots for linting errors.

type: pwa-chrome

CleanShot 2022-11-12 at 22 06 15@2x

console

CleanShot 2022-11-12 at 22 06 37@2x

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@kodiakhq kodiakhq bot merged commit 3a0065d into vercel:canary Nov 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants