Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tigris example with Next.js #42662

Merged
merged 7 commits into from Nov 15, 2022
Merged

Tigris example with Next.js #42662

merged 7 commits into from Nov 15, 2022

Conversation

adilansari
Copy link
Contributor

@adilansari adilansari commented Nov 9, 2022 •
edited

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@adilansari
Tigris example (#1)
306cb69 
* feat: Tigris example with Next.js

* Fixed linting for tigris example

* updating readme and package.json
@ijjk ijjk added the examples Issue/PR related to examples label Nov 9, 2022
@beingofexistence13
Copy link

WellDone Bro

balazsorban44
balazsorban44 requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm-lock.yaml file should be untouched by examples, could you revert those changes?

balazsorban44
balazsorban44 requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added some comments. Could you address them?

@adilansari
Cleaning up tigris example
b0cb9f7 
* Reverting pnpm lock

* removing document

* removing gitignore

* removing License

* Added note about ts-node installations
@adilansari
Copy link
Contributor Author

Thanks, added some comments. Could you address them?

Addressed! Ready for another round of review. Thanks for the help.

@adilansari adilansari requested review from balazsorban44 and removed request for huozhi November 11, 2022 06:43
@adilansari
Copy link
Contributor Author

@balazsorban44 thanks for approving. How do I get it merged?

@balazsorban44 balazsorban44 merged commit 0f8b3d6 into vercel:canary Nov 15, 2022
@balazsorban44
Copy link
Member

Merged manually. 👍 Usually PRs are merged when everything passes, but this PR was opened from an organization fork, which GitHub cannot currently auto-merge because of a bug. https://github.com/orgs/community/discussions/5634

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adilansari @beingofexistence13 @balazsorban44 @ijjk