Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve with-algolia-react-instantsearch example and convert to TypeScript #42617

Merged
merged 2 commits into from Nov 14, 2022

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Nov 8, 2022

Converted to TypeScript to match Contribution docs, and updated/simplified the example.

  • Replaced stylesheets in Head component with imported styles
  • Removed style-loader, css-loader, cross-env, prop-types packages
  • Removed custom webpack config

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Nov 8, 2022
@maxproske maxproske changed the title Convert with-algolia-react-instantsearch example to TypeScript Improve with-algolia-react-instantsearch example and convert to TypeScript Nov 8, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only had a minor comment

@maxproske
Copy link
Contributor Author

Thank you @balazsorban44. I left a comment above!

@kodiakhq kodiakhq bot merged commit 994089f into vercel:canary Nov 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants