New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RSC plugin to provide better errors #42435
Conversation
Failing test suitesCommit: 7c183f6
Expand output● ReactRefreshLogBox app › render error not shown right after syntax error
Read more about building and testing Next.js in contributing.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is incorrectly erroring in Generate PR stats https://github.com/vercel/next.js/actions/runs/3448885518/jobs/5756416759#step:6:348
This PR improves the RSC plugin for SWC to throw an error when the
"use client"
directive is in the top level, but not before other statements / expressions. For example:Code:
Error:
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
pnpm build && pnpm lint