Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert font-optimization.md syntax #42403

Merged
merged 3 commits into from Nov 3, 2022
Merged

Revert font-optimization.md syntax #42403

merged 3 commits into from Nov 3, 2022

Conversation

chibicode
Copy link
Member

@chibicode chibicode commented Nov 3, 2022 •
edited

Reverts syntax introduced in #42266

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

mrmckeb
mrmckeb previously approved these changes Nov 3, 2022
View reviewed changes
balazsorban44
balazsorban44 previously approved these changes Nov 3, 2022
View reviewed changes
ijjk
ijjk previously approved these changes Nov 3, 2022
View reviewed changes
@ijjk ijjk dismissed stale reviews from balazsorban44, mrmckeb, and themself via 370a614 November 3, 2022 18:14
@kodiakhq kodiakhq bot merged commit 6edeb9d into vercel:canary Nov 3, 2022
@chibicode chibicode changed the title Fix font-optimization.md syntax errors Revert font-optimization.md syntax Nov 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@mrmckeb mrmckeb mrmckeb left review comments

@balazsorban44 balazsorban44 balazsorban44 left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chibicode @mrmckeb @balazsorban44 @ijjk