Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update failing e2e middleware response test #42256

Merged
merged 1 commit into from Oct 31, 2022
Merged

Update failing e2e middleware response test #42256

merged 1 commit into from Oct 31, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 31, 2022

Fixes: https://github.com/vercel/next.js/actions/runs/3362784779/jobs/5576284398

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Oct 31, 2022
@ijjk ijjk marked this pull request as ready for review October 31, 2022 18:35
@ijjk ijjk merged commit a4f9d77 into vercel:canary Oct 31, 2022
@ijjk ijjk deleted the fix/failing-e2e-middleware branch October 31, 2022 18:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle