Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix revalidate check in client component #41917

Merged
merged 1 commit into from Oct 27, 2022
Merged

Fix revalidate check in client component #41917

merged 1 commit into from Oct 27, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 26, 2022

Ensures we check for the explicit type on revalidate as client components can return an object when accessing module export.

Patched deployment can be seen here https://next-13-client-page-iuqrog6hj-ijjk-testing.vercel.app/broken

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Fixes: #41890

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 26, 2022
@ijjk ijjk merged commit 9781c62 into vercel:canary Oct 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting use client on a page in the app directory crashes on Vercel deployment
4 participants
@ijjk @shuding @huozhi @styfle