Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix middleware + afterFiles SSG rewrite case #39153

Merged
merged 1 commit into from Jul 29, 2022
Merged

Fix middleware + afterFiles SSG rewrite case #39153

merged 1 commit into from Jul 29, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 29, 2022 •
edited

This ensures we properly load props when updating query information or during a route transition when afterFiles rewrites are used alongside middleware for an SSG page.

Deployment of reproduction with patch applied can be seen here

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #38794

@ijjk ijjk marked this pull request as ready for review July 29, 2022 01:22
@ijjk ijjk merged commit a154c15 into vercel:canary Jul 29, 2022
@ijjk ijjk deleted the fix/after-files-ssg-case branch July 29, 2022 01:23
@ijjk ijjk mentioned this pull request Aug 1, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static page with rewrite not getting passed page props for second rerender client side
1 participant
@ijjk