Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): Convert with-cypress example to TypeScript #38818

Merged
merged 3 commits into from Jul 21, 2022
Merged

chore(examples): Convert with-cypress example to TypeScript #38818

merged 3 commits into from Jul 21, 2022

Conversation

amorimr
Copy link
Contributor

@amorimr amorimr commented Jul 20, 2022

  • Update with-cypress example dependencies;
  • Convert with-cypress example to TypeScript as suggested in the Contribution docs.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 20, 2022
balazsorban44
balazsorban44 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 552620f into vercel:canary Jul 21, 2022
@amorimr amorimr deleted the with-cypress-typescript branch July 21, 2022 16:47
@NOUIY NOUIY mentioned this pull request Aug 12, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amorimr @balazsorban44 @ijjk