Refine scrolling into view in new router

[timneutkens]

The first version uses element.scrollIntoView() but this doesn't take into account when the element is already visble on screen, this change ensures that there is no scroll when you're already viewing the layout where a change happens.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes by running pnpm lint
• The examples guidelines are followed from our contributing doc

[ijjk]

Failing test suites

Commit: a1b06e8

pnpm testheadless test/e2e/app-dir/index.test.ts

• app dir > > should soft push

Expand output

● app dir › › should soft push

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for selector "#link"
============================================================

  304 |     return this.chain(() => {
  305 |       return page
> 306 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  307 |         .then(async (el) => {
  308 |           // it seems selenium waits longer and tests rely on this behavior
  309 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:306:10

Read more about building and testing Next.js in contributing.md.