Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure selected segment is the value of dynamic routes #38644

Merged

Conversation

timneutkens
Copy link
Member

Ensures the layout segment is provided correctly for dynamic routes.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk
Copy link
Member

ijjk commented Jul 14, 2022

Failing test suites

Commit: 891a128

pnpm testheadless test/e2e/yarn-pnp/test/pwa-example.test.ts

  • yarn PnP > should compile and serve the index page correctly progressive-web-app
Expand output

● yarn PnP › should compile and serve the index page correctly progressive-web-app

thrown: "Exceeded timeout of 120000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  21 |     let next: NextInstance
  22 |
> 23 |     beforeAll(async () => {
     |     ^
  24 |       const srcDir = join(__dirname, '../../../../examples', example)
  25 |       const srcFiles = await fs.readdir(srcDir)
  26 |

  at runTests (e2e/yarn-pnp/test/utils.ts:23:5)
  at e2e/yarn-pnp/test/pwa-example.test.ts:4:11
  at Object.<anonymous> (e2e/yarn-pnp/test/pwa-example.test.ts:3:1)

● Test suite failed to run

next dev exited unexpectedly with code/signal 1

  62 |         if (this.isStopping) return
  63 |         if (code || signal) {
> 64 |           throw new Error(
     |                 ^
  65 |             `next dev exited unexpectedly with code/signal ${code || signal}`
  66 |           )
  67 |         }

  at ChildProcess.<anonymous> (lib/next-modes/next-dev.ts:64:17)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   96 |
   97 | if (typeof afterAll === 'function') {
>  98 |   afterAll(async () => {
      |   ^
   99 |     if (nextInstance) {
  100 |       await nextInstance.destroy()
  101 |       throw new Error(

  at Object.<anonymous> (lib/e2e-utils.ts:98:3)
  at Object.<anonymous> (e2e/yarn-pnp/test/utils.ts:12:19)

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens merged commit e06983b into vercel:canary Jul 14, 2022
@timneutkens timneutkens deleted the fix/use-selected-layout-segment-value branch July 14, 2022 14:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants