Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure .client.tsx/.ts/.jsx Client Components can be imported #38591

Merged
merged 2 commits into from Jul 13, 2022
Merged

Ensure .client.tsx/.ts/.jsx Client Components can be imported #38591

merged 2 commits into from Jul 13, 2022

Conversation

timneutkens
Copy link
Member

Currently .client.ts / .client.tsx / .client.jsx throws an error as they're handled as server components incorrectly.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jul 13, 2022
huozhi
huozhi previously approved these changes Jul 13, 2022
View reviewed changes
@timneutkens timneutkens merged commit db4f032 into vercel:canary Jul 13, 2022
@timneutkens timneutkens deleted the fix/ts-client-components branch July 13, 2022 12:43
@EtheWallet

This comment was marked as spam.

Sign in to view
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timneutkens @EtheWallet @huozhi @ijjk