Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dynamic routes / catchall routes in on-demand-entries #38512

Merged
merged 2 commits into from Jul 11, 2022

Conversation

timneutkens
Copy link
Member

Ensures the on-demand entries ping does not return invalid when dynamic routes are used. There was a small bug with how the entrypoint path was constructed where it was missing tthe brackets. Downside to this is that the tree needs to hold the type of parameter in order to reverse-resolve the entrypoint that, tried to mimize that by using a short identifier

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@timneutkens timneutkens merged commit b014343 into vercel:canary Jul 11, 2022
@timneutkens timneutkens deleted the fix/on-demand-entries-ping branch July 11, 2022 12:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants