Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add trpc to examples #38272

Merged
merged 7 commits into from Jul 8, 2022

Conversation

zorrolisto
Copy link
Contributor

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Nice to have nextjs up to date always!

@ijjk ijjk added the examples Issue/PR related to examples label Jul 3, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I would like to defer to @KATT here. I wonder if tRPC already has an official example, and it would make sense to add a single README.md file here that points to their example. This would make sure that we are in sync with the latest recommendations by the tRPC team.

Copy link
Contributor

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how minimal this example is, @zorrolisto, do you wanna add it to https://github.com/trpc/trpc?

We could instead do a README.md with a few links:

@zorrolisto
Copy link
Contributor Author

thanks 🙏, so I need to remove the directories and files, and only left one README.md with the links right? @KATT

@balazsorban44
Copy link
Member

That's correct!

@kodiakhq kodiakhq bot merged commit 65ea43f into vercel:canary Jul 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants