Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @types/node-fetch to latest #36953

Merged
merged 1 commit into from May 16, 2022

Conversation

lfades
Copy link
Member

@lfades lfades commented May 16, 2022

Currently, if you try the following code while developing with Next.js inside Middleware:

const url = new URL(MY_URL)
const res = await fetch(url)

The app will work as expected, and so will the dom types for TS 4.5+. However when running next build or tsc typescript fails with:

image

The types for node-fetch have been updated to include URL so this PR updates the dependency to fix it.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member

ijjk commented May 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js update-node-fetch-types Change
buildDuration 19.1s 19.1s -62ms
buildDurationCached 7.9s 7.4s -443ms
nodeModulesSize 478 MB 478 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js update-node-fetch-types Change
/ failed reqs 0 0
/ total time (seconds) 4.673 4.701 ⚠️ +0.03
/ avg req/sec 535.03 531.78 ⚠️ -3.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.65 1.659 ⚠️ +0.01
/error-in-render avg req/sec 1514.84 1507.3 ⚠️ -7.54
Client Bundles (main, webpack)
vercel/next.js canary lfades/next.js update-node-fetch-types Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.4 kB 72.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update-node-fetch-types Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary lfades/next.js update-node-fetch-types Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.7 kB 2.7 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary lfades/next.js update-node-fetch-types Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary lfades/next.js update-node-fetch-types Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary lfades/next.js update-node-fetch-types Change
buildDuration 21.3s 21.5s ⚠️ +200ms
buildDurationCached 7.7s 7.7s -14ms
nodeModulesSize 478 MB 478 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lfades/next.js update-node-fetch-types Change
/ failed reqs 0 0
/ total time (seconds) 4.766 4.776 ⚠️ +0.01
/ avg req/sec 524.52 523.48 ⚠️ -1.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.65 1.651 0
/error-in-render avg req/sec 1515.46 1514.18 ⚠️ -1.28
Client Bundles (main, webpack)
vercel/next.js canary lfades/next.js update-node-fetch-types Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.5 kB 73.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lfades/next.js update-node-fetch-types Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary lfades/next.js update-node-fetch-types Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.8 kB 5.8 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.77 kB 2.77 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary lfades/next.js update-node-fetch-types Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary lfades/next.js update-node-fetch-types Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: c9eab6d

@kodiakhq kodiakhq bot merged commit 31a538d into vercel:canary May 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants