Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of middleware req.cookies.get() #36872

Merged
merged 3 commits into from May 12, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented May 12, 2022

Follow up to #36478

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 12, 2022
@styfle styfle marked this pull request as ready for review May 12, 2022 20:31
@styfle
Copy link
Member Author

styfle commented May 12, 2022

cc @Kikobeats @javivelasco

@ijjk
Copy link
Member

ijjk commented May 12, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
buildDuration 15.3s 15.3s -52ms
buildDurationCached 6.1s 6.1s -11ms
nodeModulesSize 475 MB 475 MB ⚠️ +346 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
/ failed reqs 0 0
/ total time (seconds) 3.768 3.825 ⚠️ +0.06
/ avg req/sec 663.44 653.61 ⚠️ -9.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.158 1.156 0
/error-in-render avg req/sec 2158.71 2162.8 +4.09
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
buildDuration 17.5s 17.3s -155ms
buildDurationCached 6.2s 6.2s ⚠️ +7ms
nodeModulesSize 475 MB 475 MB ⚠️ +346 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
/ failed reqs 0 0
/ total time (seconds) 3.788 3.792 0
/ avg req/sec 660.03 659.34 ⚠️ -0.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.162 1.148 -0.01
/error-in-render avg req/sec 2150.56 2178.38 +27.82
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-ts-types-middleware Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 6537494

@kodiakhq kodiakhq bot merged commit d67baa0 into canary May 12, 2022
@kodiakhq kodiakhq bot deleted the fix-ts-types-middleware branch May 12, 2022 21:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants