Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple entries for server components and client components #36860

Merged
merged 16 commits into from May 13, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented May 12, 2022

One major change in this PR regarding RSC is to create a separate entrypoint for .client.js components with next-flight-client-entry-loader for both server and client compilers. These entrypoints are generated and inserted to the compilers from flight-manifest-plugin after the RSC build is finished (compiler.hooks.finishMake).

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 12, 2022
@ijjk

This comment was marked as resolved.

@ijjk
Copy link
Member

ijjk commented May 12, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/0e73 Change
buildDuration 15.2s 15.3s ⚠️ +76ms
buildDurationCached 6.2s 6.2s ⚠️ +10ms
nodeModulesSize 475 MB 475 MB ⚠️ +8.99 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/0e73 Change
/ failed reqs 0 0
/ total time (seconds) 3.77 3.742 -0.03
/ avg req/sec 663.2 668.09 +4.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.175 1.147 -0.03
/error-in-render avg req/sec 2127.43 2179.39 +51.96
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/0e73 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/0e73 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/0e73 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.7 kB 2.7 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/0e73 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/0e73 Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/0e73 Change
buildDuration 17.2s 17.6s ⚠️ +365ms
buildDurationCached 6.1s 6.4s ⚠️ +280ms
nodeModulesSize 475 MB 475 MB ⚠️ +8.99 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/0e73 Change
/ failed reqs 0 0
/ total time (seconds) 3.771 3.803 ⚠️ +0.03
/ avg req/sec 662.91 657.4 ⚠️ -5.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.16 1.16
/error-in-render avg req/sec 2155.59 2154.68 ⚠️ -0.91
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/0e73 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.3 kB 29.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.2 kB 73.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/0e73 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/0e73 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.72 kB 2.72 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.8 kB 5.8 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.77 kB 2.77 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/0e73 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/0e73 Change
index.html gzip 527 B 527 B
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.59 kB 1.59 kB
Commit: a7a3f98

@shuding shuding marked this pull request as ready for review May 12, 2022 15:24
timneutkens
timneutkens previously approved these changes May 12, 2022
@timneutkens timneutkens self-requested a review May 12, 2022 20:29
@shuding shuding merged commit b122178 into vercel:canary May 13, 2022
@shuding shuding deleted the shu/0e73 branch May 13, 2022 17:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants