Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable html post optimization for react 18 #36837

Merged
merged 12 commits into from May 12, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 11, 2022

Follow up for #35888 to re-enable more test, and re-enable post processors after #36792 has better support for document.gIP with react 18. Apply post-pocessing when the the shell chunk is fully buffered.

re-enabled integration tests for react 18:

  • amphtml
  • amphtml-custom-optimizer
  • app-document
  • font-optimization

Fixes #35835

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 11, 2022
@huozhi huozhi marked this pull request as ready for review May 11, 2022 16:02
@ijjk
Copy link
Member

ijjk commented May 11, 2022

Failing test suites

Commit: 31ca263

yarn testheadless test/integration/amphtml/test/index.test.js

  • AMP Usage > AMP dev mode > should add data-ampdevmode to development script tags
  • AMP Usage > AMP dev mode > should detect the changes and display it
Expand output

● AMP Usage › AMP dev mode › should add data-ampdevmode to development script tags

expect(received).toEqual(expected) // deep equality

- Expected  - 7
+ Received  + 1

- Array [
-   "__NEXT_DATA__",
-   "/_next/static/chunks/react-refresh.js",
-   "/_next/static/chunks/polyfills.js",
-   "/_next/static/chunks/webpack.js",
-   "/_next/static/chunks/amp.js",
- ]
+ Array []

  320 |             e.startsWith('/') ? new URL(e, 'http://x.x').pathname : e
  321 |           )
> 322 |       ).toEqual([
      |         ^
  323 |         '__NEXT_DATA__',
  324 |         '/_next/static/chunks/react-refresh.js',
  325 |         '/_next/static/chunks/polyfills.js',

  at Object.<anonymous> (integration/amphtml/test/index.test.js:322:9)
      at runMicrotasks (<anonymous>)

● AMP Usage › AMP dev mode › should detect the changes and display it

TIMED OUT: /This is the hot AMP page/

This is a cold AMP page.

no AMP for you...

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:363:9)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented May 11, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js streaming/amp Change
buildDuration 15.2s 15.3s ⚠️ +164ms
buildDurationCached 6.1s 6.1s -7ms
nodeModulesSize 475 MB 475 MB ⚠️ +1.18 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js streaming/amp Change
/ failed reqs 0 0
/ total time (seconds) 3.751 3.761 ⚠️ +0.01
/ avg req/sec 666.55 664.75 ⚠️ -1.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.153 1.144 -0.01
/error-in-render avg req/sec 2168.95 2185.46 +16.51
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js streaming/amp Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js streaming/amp Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js streaming/amp Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js streaming/amp Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js streaming/amp Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js streaming/amp Change
buildDuration 17.2s 17.4s ⚠️ +123ms
buildDurationCached 6.2s 6.2s -11ms
nodeModulesSize 475 MB 475 MB ⚠️ +1.18 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js streaming/amp Change
/ failed reqs 0 0
/ total time (seconds) 3.788 3.781 -0.01
/ avg req/sec 659.89 661.13 +1.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.159 1.133 -0.03
/error-in-render avg req/sec 2156.56 2206.33 +49.77
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js streaming/amp Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js streaming/amp Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js streaming/amp Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js streaming/amp Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js streaming/amp Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 8c69f03

@huozhi huozhi marked this pull request as draft May 11, 2022 17:07
@huozhi huozhi closed this May 11, 2022
@huozhi huozhi reopened this May 11, 2022
@huozhi huozhi marked this pull request as ready for review May 11, 2022 20:35
@huozhi huozhi requested a review from shuding May 11, 2022 22:13
shuding
shuding previously approved these changes May 12, 2022
packages/next/server/post-process.ts Outdated Show resolved Hide resolved
@huozhi huozhi changed the title Enable font optimization for react 18 Enable html post optimization for react 18 May 12, 2022
@kodiakhq kodiakhq bot merged commit adb56ef into vercel:canary May 12, 2022
@huozhi huozhi deleted the streaming/amp branch May 12, 2022 18:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Optimization is not fully working
3 participants