Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#36534): enable interopClientDefaultExport for next/jest #36824

Merged
merged 2 commits into from May 11, 2022

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented May 11, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

The PR fixes #36534.

The issue is similar to #36183, where interopClientDefaultExport is not enabled.
The PR applies a fix similar to #36464, by enabling interopClientDefaultExport for next/dist/build/jest/jest.

@ijjk
Copy link
Member

ijjk commented May 11, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary SukkaW/next.js fix-36534 Change
buildDuration 16.2s 16.1s -16ms
buildDurationCached 6.4s 6.2s -220ms
nodeModulesSize 475 MB 475 MB ⚠️ +707 B
Page Load Tests Overall increase ✓
vercel/next.js canary SukkaW/next.js fix-36534 Change
/ failed reqs 0 0
/ total time (seconds) 3.952 3.944 -0.01
/ avg req/sec 632.64 633.88 +1.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.385 1.381 0
/error-in-render avg req/sec 1804.96 1809.96 +5
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js fix-36534 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js fix-36534 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js fix-36534 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js fix-36534 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js fix-36534 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary SukkaW/next.js fix-36534 Change
buildDuration 17.9s 18.1s ⚠️ +155ms
buildDurationCached 6.3s 6.3s ⚠️ +32ms
nodeModulesSize 475 MB 475 MB ⚠️ +707 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SukkaW/next.js fix-36534 Change
/ failed reqs 0 0
/ total time (seconds) 3.973 3.994 ⚠️ +0.02
/ avg req/sec 629.28 625.96 ⚠️ -3.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.394 ⚠️ +0.02
/error-in-render avg req/sec 1820.15 1793.62 ⚠️ -26.53
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js fix-36534 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js fix-36534 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js fix-36534 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js fix-36534 Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js fix-36534 Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: f2625c1

@ijjk ijjk merged commit d76bbde into vercel:canary May 11, 2022
@SukkaW SukkaW deleted the fix-36534 branch May 14, 2022 14:53
@ryami333
Copy link

ryami333 commented Jun 8, 2022

If I understand correctly that this PR is now bundled within the 12.1.7-canary then I don't think it has fixed the issue correctly. Please see my error report #37524 (which I believe has been closed erroneously). It includes a minimal reproducible example on codesandbox demonstrating that the error still persists.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong TypeScript export signature for next/jest
5 participants