Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for shell resolve with gIP is customized in react 18 #36792

Merged
merged 7 commits into from May 11, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 10, 2022

When getInitialProps is customized with react 18, since gIP requires to return html as doc property which could be used by user-land customization, we do blocking-rendering there and passdown the html to document

Fixes #36675
Closes #36419

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 10, 2022
@ijjk

This comment was marked as outdated.

@ijjk
Copy link
Member

ijjk commented May 10, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
buildDuration 20.7s 20.7s ⚠️ +8ms
buildDurationCached 7.9s 7.8s -27ms
nodeModulesSize 475 MB 475 MB ⚠️ +920 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
/ failed reqs 0 0
/ total time (seconds) 5.746 5.657 -0.09
/ avg req/sec 435.09 441.9 +6.81
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.282 2.293 ⚠️ +0.01
/error-in-render avg req/sec 1095.31 1090.28 ⚠️ -5.03
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
buildDuration 23.5s 22.8s -660ms
buildDurationCached 8s 7.8s -189ms
nodeModulesSize 475 MB 475 MB ⚠️ +920 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
/ failed reqs 0 0
/ total time (seconds) 5.506 5.35 -0.16
/ avg req/sec 454.02 467.27 +13.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.254 2.238 -0.02
/error-in-render avg req/sec 1109.1 1117.12 +8.02
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js streaming/initial-shell Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 0507473

@huozhi huozhi marked this pull request as ready for review May 10, 2022 00:42
@huozhi huozhi marked this pull request as draft May 10, 2022 01:03
@huozhi huozhi marked this pull request as ready for review May 10, 2022 04:54
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this?

@huozhi huozhi requested a review from shuding May 10, 2022 12:29
@kodiakhq kodiakhq bot merged commit 4de5b64 into vercel:canary May 11, 2022
@huozhi huozhi deleted the streaming/initial-shell branch May 11, 2022 13:32
kodiakhq bot pushed a commit that referenced this pull request May 12, 2022
Follow up for #35888 to re-enable more test, and re-enable post processors after #36792 has better support for document.gIP with react 18. Apply post-pocessing when the the shell chunk is fully buffered.

re-enabled integration tests for react 18:
- amphtml
- amphtml-custom-optimizer
- app-document
- font-optimization

Fixes #35835


## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

12.1.6 CSS generation regression
3 participants