Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x-nextjs-cache header in minimal mode #36791

Merged
merged 1 commit into from May 9, 2022
Merged

Update x-nextjs-cache header in minimal mode #36791

merged 1 commit into from May 9, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 9, 2022

This updates to skip setting the x-nextjs-cache header in minimal mode as the value will always be MISS since the incremental cache is disabled in this mode.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 9, 2022
@ijjk ijjk requested a review from styfle May 9, 2022 21:45
@ijjk ijjk merged commit 7d52589 into vercel:canary May 9, 2022
@ijjk ijjk deleted the update/nextjs-cache-header branch May 9, 2022 22:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle