Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental flag to force SWC transforms #36789

Merged
merged 2 commits into from May 10, 2022
Merged

Add experimental flag to force SWC transforms #36789

merged 2 commits into from May 10, 2022

Conversation

erikbrinkman
Copy link
Contributor

fixes #36763
fixes #36590

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    • It hasn't been accepted for implementation, although that process isn't clear, and this is a pretty trivial fix.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
    • This is somewhat inherent in the error log
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine overall, we'll probably want to use a different name when it's stable but for now it's fine.

@ijjk
Copy link
Member

ijjk commented May 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
buildDuration 18.5s 18.5s -68ms
buildDurationCached 7.2s 7.2s ⚠️ +27ms
nodeModulesSize 475 MB 475 MB ⚠️ +218 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
/ failed reqs 0 0
/ total time (seconds) 4.561 4.634 ⚠️ +0.07
/ avg req/sec 548.17 539.52 ⚠️ -8.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.567 1.584 ⚠️ +0.02
/error-in-render avg req/sec 1595.24 1578.04 ⚠️ -17.2
Client Bundles (main, webpack)
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
buildDuration 20.5s 20.6s ⚠️ +112ms
buildDurationCached 7.2s 7.4s ⚠️ +119ms
nodeModulesSize 475 MB 475 MB ⚠️ +218 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
/ failed reqs 0 0
/ total time (seconds) 4.621 4.682 ⚠️ +0.06
/ avg req/sec 541.03 533.93 ⚠️ -7.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.595 1.61 ⚠️ +0.02
/error-in-render avg req/sec 1567.69 1553.1 ⚠️ -14.59
Client Bundles (main, webpack)
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary erikbrinkman/next.js opt-in-swc Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 6d7daec

@kodiakhq kodiakhq bot merged commit c7b2083 into vercel:canary May 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
@erikbrinkman erikbrinkman deleted the opt-in-swc branch July 29, 2022 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to opt-in to swc even in the presence of a bable file Docs: how to opt back into SWC
3 participants