Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerly load swc bindings for wasm fallback for jest #36784

Merged
merged 2 commits into from May 12, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 9, 2022

Follow-up to #36612 this updates to eagerly load the swc bindings unless babel is being used so that we don't wait for the transform calls to initialize swc. Eagerly loading in jest also allows us to fallback to the wasm bindings when previously we couldn't since they needed to wait for the import.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 9, 2022
@ijjk ijjk marked this pull request as ready for review May 9, 2022 19:06
@ijjk
Copy link
Member Author

ijjk commented May 9, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
buildDuration 18.7s 18.9s ⚠️ +241ms
buildDurationCached 7.4s 7.2s -243ms
nodeModulesSize 475 MB 475 MB ⚠️ +1.92 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
/ failed reqs 0 0
/ total time (seconds) 5.051 5.049 0
/ avg req/sec 494.99 495.13 +0.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.042 2.041 0
/error-in-render avg req/sec 1224.37 1225.15 +0.78
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
buildDuration 21.3s 21.5s ⚠️ +264ms
buildDurationCached 7.2s 7.2s -21ms
nodeModulesSize 475 MB 475 MB ⚠️ +1.92 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
/ failed reqs 0 0
/ total time (seconds) 5.122 5.162 ⚠️ +0.04
/ avg req/sec 488.1 484.34 ⚠️ -3.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.969 2.053 ⚠️ +0.08
/error-in-render avg req/sec 1269.8 1217.79 ⚠️ -52.01
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/eagerly-load-bindings Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 8d34b3e

@kodiakhq kodiakhq bot merged commit 8e401ae into vercel:canary May 12, 2022
@ijjk ijjk deleted the update/eagerly-load-bindings branch May 12, 2022 13:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants