Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root component handling #36781

Merged
merged 5 commits into from May 10, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 9, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 9, 2022
@ijjk ijjk marked this pull request as ready for review May 9, 2022 17:42
@ijjk
Copy link
Member Author

ijjk commented May 9, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
buildDuration 19.2s 19.4s ⚠️ +215ms
buildDurationCached 7.3s 7.5s ⚠️ +189ms
nodeModulesSize 475 MB 475 MB ⚠️ +2.26 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
/ failed reqs 0 0
/ total time (seconds) 5.297 5.133 -0.16
/ avg req/sec 472 487.09 +15.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.991 2.143 ⚠️ +0.15
/error-in-render avg req/sec 1255.91 1166.6 ⚠️ -89.31
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
buildDuration 21.5s 21.7s ⚠️ +223ms
buildDurationCached 7.4s 7.5s ⚠️ +83ms
nodeModulesSize 475 MB 475 MB ⚠️ +2.26 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
/ failed reqs 0 0
/ total time (seconds) 5.067 5.056 -0.01
/ avg req/sec 493.39 494.44 +1.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.991 2.067 ⚠️ +0.08
/error-in-render avg req/sec 1255.94 1209.21 ⚠️ -46.73
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/root-layout-handling Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: ca170fb

@ijjk ijjk requested a review from padmaia as a code owner May 9, 2022 19:40
@timneutkens timneutkens merged commit 482fe25 into vercel:canary May 10, 2022
@timneutkens timneutkens deleted the update/root-layout-handling branch May 10, 2022 16:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants