Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react dom server node api to detect react root is enabled #36749

Merged
merged 2 commits into from May 7, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 7, 2022

x-ref: #36552 (comment)
x-ref: preactjs/next-plugin-preact#59

preact/compat doesn't have /server.browser exports, to make it work with latest of next.js:

  • use react-dom/server to detect if it could opt-in streaming rendering by checking react 18 renderToPipeableStream API in short time fix. In long term preact/compatshould support /server.browser that same with react 17.
  • Also filed a PR to next-plugin-preact to skip chunk-prepending to pages in edge compiler

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 7, 2022
@ijjk
Copy link
Member

ijjk commented May 7, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js react-dom-imports Change
buildDuration 16.3s 16.2s -16ms
buildDurationCached 6.5s 6.4s -106ms
nodeModulesSize 475 MB 475 MB ⚠️ +94 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js react-dom-imports Change
/ failed reqs 0 0
/ total time (seconds) 3.797 4.019 ⚠️ +0.22
/ avg req/sec 658.38 622.06 ⚠️ -36.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.42 1.423 0
/error-in-render avg req/sec 1760.81 1756.44 ⚠️ -4.37
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js react-dom-imports Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js react-dom-imports Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js react-dom-imports Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js react-dom-imports Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js react-dom-imports Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js react-dom-imports Change
buildDuration 18.4s 18.3s -44ms
buildDurationCached 6.4s 6.3s -59ms
nodeModulesSize 475 MB 475 MB ⚠️ +94 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js react-dom-imports Change
/ failed reqs 0 0
/ total time (seconds) 3.75 4.025 ⚠️ +0.28
/ avg req/sec 666.63 621.1 ⚠️ -45.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.388 1.409 ⚠️ +0.02
/error-in-render avg req/sec 1800.89 1774.3 ⚠️ -26.59
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js react-dom-imports Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js react-dom-imports Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js react-dom-imports Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js react-dom-imports Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js react-dom-imports Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 4c74f37

@huozhi huozhi marked this pull request as ready for review May 7, 2022 17:53
@kodiakhq kodiakhq bot merged commit a84672e into vercel:canary May 7, 2022
@huozhi huozhi deleted the react-dom-imports branch May 7, 2022 18:46
@adhirajsinghchauhan
Copy link

  • In long term preact/compatshould support /server.browser

@huozhi done in preactjs/preact#3544

@JoviDeCroock
Copy link

@huozhi
Copy link
Member Author

huozhi commented Jun 7, 2022

@JoviDeCroock @adhirajsinghchauhan Hi thanks for bumping the issue. We've also removed the /server.browser usage in next.js. But it still requires preactjs/next-plugin-preact#59 to be landed as mentioned in PR description to avoid breaking the bundling with new webpack architecture in nextjs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants