Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak routing tests #36667

Merged
merged 14 commits into from May 5, 2022
Merged

Tweak routing tests #36667

merged 14 commits into from May 5, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 3, 2022

x-ref: #36618

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label May 3, 2022
@ijjk
Copy link
Member Author

ijjk commented May 3, 2022 •
edited

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/routing-tests Change
buildDuration 15.3s 15.5s ⚠️ +241ms
buildDurationCached 5.6s 6s ⚠️ +443ms
nodeModulesSize 475 MB 475 MB -3.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/routing-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.39 3.583 ⚠️ +0.19
/ avg req/sec 737.56 697.67 ⚠️ -39.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.262 1.363 ⚠️ +0.1
/error-in-render avg req/sec 1981.64 1833.95 ⚠️ -147.69
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/routing-tests Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.8 kB 28.8 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/routing-tests Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/routing-tests Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.08 kB 3.08 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.7 kB 5.7 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.64 kB 2.64 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/routing-tests Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/routing-tests Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/routing-tests Change
buildDuration 17.8s 17.5s -263ms
buildDurationCached 5.8s 6s ⚠️ +204ms
nodeModulesSize 475 MB 475 MB -3.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/routing-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.622 3.5 -0.12
/ avg req/sec 690.2 714.23 +24.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.383 1.304 -0.08
/error-in-render avg req/sec 1807.71 1917.68 +109.97
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/routing-tests Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 73.1 kB 73.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/routing-tests Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/routing-tests Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 3.08 kB 3.08 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.79 kB 5.79 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.76 kB 2.76 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.5 kB 16.5 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/routing-tests Change
_buildManifest.js gzip 456 B 456 B ✓
Overall change 456 B 456 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/routing-tests Change
index.html gzip 530 B 530 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 9e84c60

@ijjk ijjk added the type: next label May 4, 2022
@timneutkens timneutkens marked this pull request as ready for review May 5, 2022 11:15
@timneutkens timneutkens merged commit e8a8220 into vercel:canary May 5, 2022
@timneutkens timneutkens deleted the update/routing-tests branch May 5, 2022 11:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @timneutkens