Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial handling for routing tests #36635

Merged
merged 2 commits into from May 3, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 3, 2022

x-ref: #36618

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 3, 2022
@ijjk
Copy link
Member Author

ijjk commented May 3, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
buildDuration 15.3s 15.4s ⚠️ +104ms
buildDurationCached 6.2s 6.1s -91ms
nodeModulesSize 475 MB 475 MB ⚠️ +61.9 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
/ failed reqs 0 0
/ total time (seconds) 3.492 3.491 0
/ avg req/sec 715.88 716.22 +0.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.171 1.161 -0.01
/error-in-render avg req/sec 2135.38 2153.25 +17.87
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
buildDuration 17.2s 17.4s ⚠️ +159ms
buildDurationCached 6.1s 6.1s -19ms
nodeModulesSize 475 MB 475 MB ⚠️ +61.9 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
/ failed reqs 0 0
/ total time (seconds) 3.512 3.519 ⚠️ +0.01
/ avg req/sec 711.88 710.34 ⚠️ -1.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.181 1.185 0
/error-in-render avg req/sec 2116.11 2110.44 ⚠️ -5.67
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/routing-experiment-handling Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: f18982c

@ijjk ijjk marked this pull request as ready for review May 3, 2022 01:14
@kodiakhq kodiakhq bot merged commit 44f436b into vercel:canary May 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants