Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swc jest pagesDir config #36623

Merged
merged 1 commit into from May 2, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 2, 2022

This updates the pagesDir config for the new return shape updated in #36619, no additional tests were added as existing tests were failing from this.

x-ref: https://github.com/vercel/next.js/runs/6257712883?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6257712805?check_suite_focus=true
x-ref: #36619

@ijjk
Copy link
Member Author

ijjk commented May 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
buildDuration 15.4s 15.3s -137ms
buildDurationCached 6.2s 5.7s -415ms
nodeModulesSize 463 MB 463 MB ⚠️ +25 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
/ failed reqs 0 0
/ total time (seconds) 3.695 3.495 -0.2
/ avg req/sec 676.54 715.21 +38.67
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.356 1.31 -0.05
/error-in-render avg req/sec 1844.02 1908.79 +64.77
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
buildDuration 17s 16.9s -101ms
buildDurationCached 6.1s 5.7s -336ms
nodeModulesSize 463 MB 463 MB ⚠️ +25 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
/ failed reqs 0 0
/ total time (seconds) 3.704 3.51 -0.19
/ avg req/sec 675.02 712.25 +37.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.354 1.26 -0.09
/error-in-render avg req/sec 1846.82 1984.88 +138.06
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/jest-pages-dir Change
index.html gzip 527 B 527 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 525 B
Overall change 1.59 kB 1.59 kB
Commit: dad408b

@kodiakhq kodiakhq bot merged commit c905fda into vercel:canary May 2, 2022
@ijjk ijjk deleted the fix/jest-pages-dir branch May 2, 2022 15:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants