Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update findPagesDir #36619

Merged
merged 3 commits into from May 2, 2022
Merged

Conversation

timneutkens
Copy link
Member

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Co-Authored-By: JJ Kasper <22380829+ijjk@users.noreply.github.com>
packages/next/lib/find-pages-dir.ts Outdated Show resolved Hide resolved
packages/next/lib/find-pages-dir.ts Show resolved Hide resolved
timneutkens and others added 2 commits May 2, 2022 14:30
Co-Authored-By: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Co-Authored-By: Jiachi Liu <4800338+huozhi@users.noreply.github.com>
@ijjk
Copy link
Member

ijjk commented May 2, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
buildDuration 15.6s 17.2s ⚠️ +1.6s
buildDurationCached 6.4s 6.2s -282ms
nodeModulesSize 463 MB 463 MB ⚠️ +1.69 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
/ failed reqs 0 0
/ total time (seconds) 4.248 5.374 ⚠️ +1.13
/ avg req/sec 588.56 465.18 ⚠️ -123.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.367 1.288 -0.08
/error-in-render avg req/sec 1829.13 1941.29 +112.16
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
buildDuration 18s 17.2s -822ms
buildDurationCached 5.9s 6.5s ⚠️ +533ms
nodeModulesSize 463 MB 463 MB ⚠️ +1.69 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
/ failed reqs 0 0
/ total time (seconds) 3.559 3.496 -0.06
/ avg req/sec 702.43 715.05 +12.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.359 1.389 ⚠️ +0.03
/error-in-render avg req/sec 1839.04 1800.31 ⚠️ -38.73
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/more-root-dir Change
index.html gzip 527 B 527 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 525 B
Overall change 1.59 kB 1.59 kB
Commit: a4004df

@timneutkens timneutkens merged commit 4eee0e3 into vercel:canary May 2, 2022
@timneutkens timneutkens deleted the add/more-root-dir branch May 2, 2022 13:07
kodiakhq bot pushed a commit that referenced this pull request May 2, 2022
This updates the `pagesDir` config for the new return shape updated in #36619, no additional tests were added as existing tests were failing from this. 

x-ref: https://github.com/vercel/next.js/runs/6257712883?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6257712805?check_suite_focus=true
x-ref: #36619
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants