Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush initial styled-jsx in gIP first in concurrent rendering #36594

Merged
merged 3 commits into from May 2, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 30, 2022

Bug

If we're flushing styled-jsx collected styles from both Document.gIP and flush effects in react 18, we will get duplicated styled-jsx in both head (from gIP) and body (from flush effects). But when there's jsx styles under Suspense, gIP cannot collect all the ones (suspended styles are missing).

Solution

flush initial styles in gIP, keep other suspended styles in body

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 30, 2022
@ijjk

This comment was marked as outdated.

@ijjk
Copy link
Member

ijjk commented Apr 30, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
buildDuration 15.4s 15.9s ⚠️ +508ms
buildDurationCached 6.2s 6.3s ⚠️ +85ms
nodeModulesSize 463 MB 463 MB ⚠️ +702 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
/ failed reqs 0 0
/ total time (seconds) 3.659 3.618 -0.04
/ avg req/sec 683.15 690.9 +7.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.327 1.303 -0.02
/error-in-render avg req/sec 1883.58 1918.42 +34.84
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
buildDuration 17.5s 17.7s ⚠️ +232ms
buildDurationCached 6.2s 6.3s ⚠️ +99ms
nodeModulesSize 463 MB 463 MB ⚠️ +702 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
/ failed reqs 0 0
/ total time (seconds) 3.633 3.646 ⚠️ +0.01
/ avg req/sec 688.13 685.67 ⚠️ -2.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.336 1.354 ⚠️ +0.02
/error-in-render avg req/sec 1871.01 1846.88 ⚠️ -24.13
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/duplicated-styled-jsx-styles Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 4e20a12

@huozhi huozhi marked this pull request as ready for review May 1, 2022 00:05
@huozhi huozhi marked this pull request as draft May 1, 2022 00:31
@huozhi huozhi force-pushed the fix/duplicated-styled-jsx-styles branch from 81ce040 to 0483d06 Compare May 1, 2022 08:05
@huozhi huozhi requested a review from shuding May 1, 2022 08:06
@huozhi huozhi marked this pull request as ready for review May 1, 2022 08:32
shuding
shuding previously approved these changes May 2, 2022
@shuding shuding self-requested a review May 2, 2022 19:47
@huozhi huozhi changed the title Use flushed effects to generate styled-jsx styles insted of gIP Dedupe duplicate styled-jsx styles under head in concurrent rendering May 2, 2022
@huozhi huozhi changed the title Dedupe duplicate styled-jsx styles under head in concurrent rendering Flush initial styled-jsx in gIP first in concurrent rendering May 2, 2022
@shuding shuding merged commit fcec758 into vercel:canary May 2, 2022
@huozhi huozhi deleted the fix/duplicated-styled-jsx-styles branch May 2, 2022 20:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants