Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing E2E deployment test cases #36368

Merged
merged 2 commits into from Apr 22, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 21, 2022

This continues off of #36285 fixing some of the failing test cases noticed when running the E2E tests against deployments. After these are resolved the tests will be added to our CI flow after each canary release.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: #36285

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 21, 2022
@ijjk
Copy link
Member Author

ijjk commented Apr 21, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
buildDuration 15.7s 15.6s -128ms
buildDurationCached 6.2s 6.1s -102ms
nodeModulesSize 481 MB 481 MB ⚠️ +3.21 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
/ failed reqs 0 0
/ total time (seconds) 3.203 3.178 -0.02
/ avg req/sec 780.54 786.69 +6.15
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.382 1.356 -0.03
/error-in-render avg req/sec 1809.06 1843.3 +34.24
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
buildDuration 17.7s 17.8s ⚠️ +128ms
buildDurationCached 6s 6.2s ⚠️ +225ms
nodeModulesSize 481 MB 481 MB ⚠️ +3.21 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
/ failed reqs 0 0
/ total time (seconds) 3.204 3.169 -0.04
/ avg req/sec 780.29 788.78 +8.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.349 1.384 ⚠️ +0.03
/error-in-render avg req/sec 1852.75 1806.09 ⚠️ -46.66
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/deploy-mismatches Change
index.html gzip 528 B 528 B
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.59 kB 1.59 kB
Commit: 46ed0c2

@ijjk ijjk marked this pull request as ready for review April 21, 2022 23:55
@kodiakhq kodiakhq bot merged commit 7c6052a into vercel:canary Apr 22, 2022
@ijjk ijjk deleted the fix/deploy-mismatches branch April 22, 2022 15:14
kodiakhq bot pushed a commit that referenced this pull request Apr 26, 2022
This continues off of the change in #36368 and ensures a fallback rewrite does not influence the `asPath` as these are only matched when a filesystem or dynamic route aren't matched. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

x-ref: #36368
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants