Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add support for useDefineForClassFields typescript option #36335

Merged
merged 4 commits into from Apr 21, 2022

Conversation

Chastrlove
Copy link
Contributor

@Chastrlove Chastrlove commented Apr 21, 2022

Fixes: #35721

Bug

  • Related issues linked using fixes #35721

  • Integration tests added

  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #35721
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Apr 21, 2022

Failing test suites

Commit: 60aa1ba

yarn testheadless test/integration/amphtml/test/index.test.js

  • AMP Usage > AMP dev mode > should detect changes to component and refresh an AMP page
  • AMP Usage > AMP dev mode > should not reload unless the page is edited for an AMP page
Expand output

● AMP Usage › AMP dev mode › should detect changes to component and refresh an AMP page

TIMED OUT: /hi/

hello

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:417:7)

● AMP Usage › AMP dev mode › should not reload unless the page is edited for an AMP page

TIMED OUT: /I'm an AMP page!/

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:431:9)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 21, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
buildDuration 17.3s 17s -339ms
buildDurationCached 6.5s 6.4s -106ms
nodeModulesSize 485 MB 485 MB ⚠️ +527 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
/ failed reqs 0 0
/ total time (seconds) 3.33 3.386 ⚠️ +0.06
/ avg req/sec 750.73 738.36 ⚠️ -12.37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.332 1.369 ⚠️ +0.04
/error-in-render avg req/sec 1876.66 1826.81 ⚠️ -49.85
Client Bundles (main, webpack)
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
buildDuration 19.9s 20s ⚠️ +101ms
buildDurationCached 6.5s 6.5s -52ms
nodeModulesSize 485 MB 485 MB ⚠️ +527 B
Page Load Tests Overall increase ✓
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
/ failed reqs 0 0
/ total time (seconds) 3.34 3.344 0
/ avg req/sec 748.58 747.56 ⚠️ -1.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.359 1.345 -0.01
/error-in-render avg req/sec 1839.53 1859.28 +19.75
Client Bundles (main, webpack)
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary Chastrlove/next.js feat/useDefineForClassFields Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 60aa1ba

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Great PR 💯

@timneutkens timneutkens merged commit 9fe2f26 into vercel:canary Apr 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for useDefineForClassFields typescript option
3 participants